fix(capture_entropy): add missing back button for cancel path#113
Merged
Merged
Conversation
Owner
|
It's a redundant path but it's more intuitive. I'm ok with it |
Contributor
Author
|
@odudex please check |
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
capture_entropy_page_create()had no explicit cancel path — the only exits were tapping the camera frame or choosing "No" in the low-entropy dialog. A user who navigates here accidentally is stuck.snapshot_page_create()indev_tools/snapshot.cis structurally identical and already has a back button; this was a copy-paste omission.back_btn_cb(withclosingguard, matching thelow_entropy_prompt_cbpattern) and callsui_create_back_button()incapture_entropy_page_create().entropy_from_camera.c) already handles cancel correctly:return_from_capture_cbcheckscapture_entropy_has_result()and routes back to the word count menu if no entropy was captured — no caller changes needed.Files changed
main/pages/capture_entropy.c— +1 include, +9 lines callback, +1 line button creation. No other files changed.